Chart schemas, deployer script validation, and ci integration #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule of thumbs: 1. Always chomp left 2. Chomp right if no content has been rendered so far in a file or named template.
This was referenced Mar 2, 2022
consideRatio
commented
Mar 2, 2022
Comment on lines
-1
to
-7
| scratchBucket: | ||
| # Enable a 'scratch' bucket per-hub, with read-write permissions for all | ||
| # users. This will set a `SCRATCH_BUCKET` env variable (and a PANGEO_SCRATCH variable | ||
| # too, for backwards compatibility). Users can share data with each other using | ||
| # this bucket. | ||
| enabled: true | ||
|
|
There was a problem hiding this comment.
This configuration section was silently ignored.
I opened #1046 to reflect removing this instead of setting it correctly in a way that would make it be respected. If I would have set this correctly, I would have potentially changed behavior etc and I didn't want to do that as part of this PR.
sgibson91
reviewed
Mar 2, 2022
sgibson91
approved these changes
Mar 2, 2022
|
I am going to merge this now as I'd like to use some of the functionality added in the deployer in #1047 to validate our support chart 🎉 |
|
I updated all the clusters/hubs helm charts locally and all is fine - so any failures in CI leftover are flakey tests |
|
Lovely work, @consideRatio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
helmCLI that will validate any passed helm chart values.helm templatecommand against the chart in question with the non-encrypted helm chart values files.validatecommand by using the non-encrypted helm chart values files.requirements.txtis now purely dependencies for the deployer scriptdev-requirements.txtis now purely dependencies for scripts in the extra_scripts folder etcTest failure unrelated
The test failure is unrelated and is resolved by #1044.