Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub auth for leap grafana and enable "allow_sign_up" for 2i2c #1460

Merged

Conversation

GeorgianaElena
Copy link
Member

Follow-up to #1437

Reference: #1279

@GeorgianaElena GeorgianaElena marked this pull request as ready for review June 23, 2022 11:27
@GeorgianaElena GeorgianaElena changed the title Enable GitHub auth for leap grafana Enable GitHub auth for leap grafana and enable "allow_sign_up" for 2i2c Jun 23, 2022
@GeorgianaElena GeorgianaElena requested a review from a team June 23, 2022 11:47
@GeorgianaElena
Copy link
Member Author

I've deployed this and it works

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeorgianaElena GeorgianaElena merged commit 8d73d69 into 2i2c-org:master Jun 23, 2022
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster

@GeorgianaElena GeorgianaElena deleted the enable-github-auth-leap branch June 23, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants