wip: feat: convert everything to standalone and fix build errors

.eslintrc.json

@@ -139,7 +139,6 @@
           }
         ],
         "@angular-eslint/no-attribute-decorator": "error",
-        "@angular-eslint/no-forward-ref": "error",
         "@angular-eslint/no-output-native": "warn",
         "@angular-eslint/no-output-on-prefix": "warn",
         "@angular-eslint/no-conflicting-lifecycle": "warn",

src/app/access-control/access-control.module.ts

@@ -28,36 +28,34 @@ export const ValidateEmailErrorStateMatcher: DynamicErrorMessagesMatcher =
   };
 
 @NgModule({
-  imports: [
-    CommonModule,
-    SharedModule,
-    RouterModule,
-    AccessControlRoutingModule,
-    FormModule,
-    NgbAccordionModule,
-    SearchModule,
-    AccessControlFormModule,
-  ],
-  exports: [
-    MembersListComponent,
-  ],
-  declarations: [
-    EPeopleRegistryComponent,
-    EPersonFormComponent,
-    GroupsRegistryComponent,
-    GroupFormComponent,
-    SubgroupsListComponent,
-    MembersListComponent,
-    BulkAccessComponent,
-    BulkAccessBrowseComponent,
-    BulkAccessSettingsComponent,
-  ],
-  providers: [
-    {
-      provide: DYNAMIC_ERROR_MESSAGES_MATCHER,
-      useValue: ValidateEmailErrorStateMatcher
-    },
-  ]
+    imports: [
+        CommonModule,
+        SharedModule,
+        RouterModule,
+        AccessControlRoutingModule,
+        FormModule,
+        NgbAccordionModule,
+        SearchModule,
+        AccessControlFormModule,
+        EPeopleRegistryComponent,
+        EPersonFormComponent,
+        GroupsRegistryComponent,
+        GroupFormComponent,
+        SubgroupsListComponent,
+        MembersListComponent,
+        BulkAccessComponent,
+        BulkAccessBrowseComponent,
+        BulkAccessSettingsComponent
+    ],
+    exports: [
+        MembersListComponent,
+    ],
+    providers: [
+        {
+            provide: DYNAMIC_ERROR_MESSAGES_MATCHER,
+            useValue: ValidateEmailErrorStateMatcher
+        },
+    ]
 })
 /**
  * This module handles all components related to the access control pages

src/app/access-control/bulk-access/browse/bulk-access-browse.component.spec.ts

@@ -28,17 +28,17 @@ describe('BulkAccessBrowseComponent', () => {
   const selectableListService = jasmine.createSpyObj('SelectableListService', ['getSelectableList', 'deselectAll']);
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
-      imports: [
+    imports: [
         NgbAccordionModule,
         NgbNavModule,
-        TranslateModule.forRoot()
-      ],
-      declarations: [BulkAccessBrowseComponent],
-      providers: [ { provide: SelectableListService, useValue: selectableListService }, ],
-      schemas: [
+        TranslateModule.forRoot(),
+        BulkAccessBrowseComponent
+    ],
+    providers: [{ provide: SelectableListService, useValue: selectableListService },],
+    schemas: [
         NO_ERRORS_SCHEMA
-      ]
-    }).compileComponents();
+    ]
+}).compileComponents();
   }));
 
   beforeEach(() => {

src/app/access-control/bulk-access/browse/bulk-access-browse.component.ts

@@ -14,6 +14,19 @@ import { createSuccessfulRemoteDataObject } from '../../../shared/remote-data.ut
 import { PageInfo } from '../../../core/shared/page-info.model';
 import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
 import { hasValue } from '../../../shared/empty.util';
+import { PaginationComponent } from '../../../shared/pagination/pagination.component';
+import { AsyncPipe, NgForOf, NgIf } from '@angular/common';
+import { NgbAccordionModule, NgbNavModule } from '@ng-bootstrap/ng-bootstrap';
+import { TranslateModule } from '@ngx-translate/core';
+import { ThemedSearchComponent } from '../../../shared/search/themed-search.component';
+import { BrowserOnlyPipe } from '../../../shared/utils/browser-only.pipe';
+import { NgxPaginationModule } from 'ngx-pagination';
+import {
+  SelectableListItemControlComponent
+} from '../../../shared/object-collection/shared/selectable-list-item-control/selectable-list-item-control.component';
+import {
+  ListableObjectComponentLoaderComponent
+} from '../../../shared/object-collection/shared/listable-object/listable-object-component-loader.component';
 
 @Component({
   selector: 'ds-bulk-access-browse',
@@ -24,7 +37,22 @@ import { hasValue } from '../../../shared/empty.util';
       provide: SEARCH_CONFIG_SERVICE,
       useClass: SearchConfigurationService
     }
-  ]
+  ],
+  imports: [
+    PaginationComponent,
+    AsyncPipe,
+    NgbAccordionModule,
+    TranslateModule,
+    NgIf,
+    NgbNavModule,
+    ThemedSearchComponent,
+    BrowserOnlyPipe,
+    NgForOf,
+    NgxPaginationModule,
+    SelectableListItemControlComponent,
+    ListableObjectComponentLoaderComponent
+  ],
+  standalone: true
 })
 export class BulkAccessBrowseComponent implements OnInit, OnDestroy {
 

src/app/access-control/bulk-access/bulk-access.component.spec.ts

@@ -69,18 +69,18 @@ describe('BulkAccessComponent', () => {
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      imports: [
+    imports: [
         RouterTestingModule,
-        TranslateModule.forRoot()
-      ],
-      declarations: [ BulkAccessComponent ],
-      providers: [
+        TranslateModule.forRoot(),
+        BulkAccessComponent
+    ],
+    providers: [
         { provide: BulkAccessControlService, useValue: bulkAccessControlServiceMock },
         { provide: NotificationsService, useValue: NotificationsServiceStub },
         { provide: SelectableListService, useValue: selectableListServiceMock }
-      ],
-      schemas: [NO_ERRORS_SCHEMA]
-    })
+    ],
+    schemas: [NO_ERRORS_SCHEMA]
+})
       .compileComponents();
   });
 

src/app/access-control/bulk-access/bulk-access.component.ts

@@ -7,11 +7,19 @@ import { BulkAccessSettingsComponent } from './settings/bulk-access-settings.com
 import { BulkAccessControlService } from '../../shared/access-control-form-container/bulk-access-control.service';
 import { SelectableListState } from '../../shared/object-list/selectable-list/selectable-list.reducer';
 import { SelectableListService } from '../../shared/object-list/selectable-list/selectable-list.service';
+import { TranslateModule } from '@ngx-translate/core';
+import { BulkAccessBrowseComponent } from './browse/bulk-access-browse.component';
 
 @Component({
   selector: 'ds-bulk-access',
   templateUrl: './bulk-access.component.html',
-  styleUrls: ['./bulk-access.component.scss']
+  styleUrls: ['./bulk-access.component.scss'],
+  imports: [
+    TranslateModule,
+    BulkAccessSettingsComponent,
+    BulkAccessBrowseComponent
+  ],
+  standalone: true
 })
 export class BulkAccessComponent implements OnInit {
 

src/app/access-control/bulk-access/settings/bulk-access-settings.component.spec.ts

@@ -3,6 +3,9 @@ import { NgbAccordionModule } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
 import { BulkAccessSettingsComponent } from './bulk-access-settings.component';
 import { NO_ERRORS_SCHEMA } from '@angular/core';
+import {
+  AccessControlFormContainerComponent
+} from '../../../shared/access-control-form-container/access-control-form-container.component';
 
 describe('BulkAccessSettingsComponent', () => {
   let component: BulkAccessSettingsComponent;
@@ -41,10 +44,13 @@ describe('BulkAccessSettingsComponent', () => {
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      imports: [NgbAccordionModule, TranslateModule.forRoot()],
-      declarations: [BulkAccessSettingsComponent],
-      schemas: [NO_ERRORS_SCHEMA]
-    }).compileComponents();
+    imports: [NgbAccordionModule, TranslateModule.forRoot(), BulkAccessSettingsComponent],
+    schemas: [NO_ERRORS_SCHEMA]
+})
+      .overrideComponent(BulkAccessSettingsComponent, {
+        remove: { imports: [AccessControlFormContainerComponent]}
+      })
+      .compileComponents();
   });
 
   beforeEach(() => {

src/app/access-control/bulk-access/settings/bulk-access-settings.component.ts

@@ -2,12 +2,22 @@ import { Component, ViewChild } from '@angular/core';
 import {
   AccessControlFormContainerComponent
 } from '../../../shared/access-control-form-container/access-control-form-container.component';
+import { NgbAccordionModule } from '@ng-bootstrap/ng-bootstrap';
+import { TranslateModule } from '@ngx-translate/core';
+import { NgIf } from '@angular/common';
 
 @Component({
   selector: 'ds-bulk-access-settings',
   templateUrl: 'bulk-access-settings.component.html',
   styleUrls: ['./bulk-access-settings.component.scss'],
-  exportAs: 'dsBulkSettings'
+  exportAs: 'dsBulkSettings',
+  imports: [
+    NgbAccordionModule,
+    TranslateModule,
+    NgIf,
+    AccessControlFormContainerComponent
+  ],
+  standalone: true
 })
 export class BulkAccessSettingsComponent {
 

src/app/access-control/epeople-registry/epeople-registry.component.spec.ts

@@ -27,6 +27,9 @@ import { RequestService } from '../../core/data/request.service';
 import { PaginationService } from '../../core/pagination/pagination.service';
 import { PaginationServiceStub } from '../../shared/testing/pagination-service.stub';
 import { FindListOptions } from '../../core/data/find-list-options.model';
+import { EPersonFormComponent } from './eperson-form/eperson-form.component';
+import { ThemedLoadingComponent } from '../../shared/loading/themed-loading.component';
+import { PaginationComponent } from '../../shared/pagination/pagination.component';
 
 describe('EPeopleRegistryComponent', () => {
   let component: EPeopleRegistryComponent;
@@ -123,26 +126,34 @@ describe('EPeopleRegistryComponent', () => {
 
     paginationService = new PaginationServiceStub();
     TestBed.configureTestingModule({
-      imports: [CommonModule, NgbModule, FormsModule, ReactiveFormsModule, BrowserModule,
+    imports: [CommonModule, NgbModule, FormsModule, ReactiveFormsModule, BrowserModule,
         TranslateModule.forRoot({
-          loader: {
-            provide: TranslateLoader,
-            useClass: TranslateLoaderMock
-          }
-        }),
-      ],
-      declarations: [EPeopleRegistryComponent],
+            loader: {
+                provide: TranslateLoader,
+                useClass: TranslateLoaderMock
+            }
+        }), EPeopleRegistryComponent],
       providers: [
-        { provide: EPersonDataService, useValue: ePersonDataServiceStub },
-        { provide: NotificationsService, useValue: new NotificationsServiceStub() },
-        { provide: AuthorizationDataService, useValue: authorizationService },
-        { provide: FormBuilderService, useValue: builderService },
-        { provide: Router, useValue: new RouterStub() },
-        { provide: RequestService, useValue: jasmine.createSpyObj('requestService', ['removeByHrefSubstring']) },
-        { provide: PaginationService, useValue: paginationService }
+        {provide: EPersonDataService, useValue: ePersonDataServiceStub},
+        {provide: NotificationsService, useValue: new NotificationsServiceStub()},
+        {provide: AuthorizationDataService, useValue: authorizationService},
+        {provide: FormBuilderService, useValue: builderService},
+        {provide: Router, useValue: new RouterStub()},
+        {provide: RequestService, useValue: jasmine.createSpyObj('requestService', ['removeByHrefSubstring'])},
+        {provide: PaginationService, useValue: paginationService}
       ],
       schemas: [NO_ERRORS_SCHEMA]
-    }).compileComponents();
+    })
+      .overrideComponent(EPeopleRegistryComponent, {
+        remove: {
+          imports: [
+            EPersonFormComponent,
+            ThemedLoadingComponent,
+            PaginationComponent,
+          ]
+        }
+      })
+      .compileComponents();
   }));
 
   beforeEach(() => {

src/app/access-control/epeople-registry/epeople-registry.component.ts

@@ -1,7 +1,7 @@
 import { Component, OnDestroy, OnInit } from '@angular/core';
-import { UntypedFormBuilder } from '@angular/forms';
+import { ReactiveFormsModule, UntypedFormBuilder } from '@angular/forms';
 import { Router } from '@angular/router';
-import { TranslateService } from '@ngx-translate/core';
+import { TranslateModule, TranslateService } from '@ngx-translate/core';
 import { BehaviorSubject, combineLatest, Observable, Subscription } from 'rxjs';
 import { map, switchMap, take } from 'rxjs/operators';
 import { buildPaginatedList, PaginatedList } from '../../core/data/paginated-list.model';
@@ -22,10 +22,26 @@ import { PageInfo } from '../../core/shared/page-info.model';
 import { NoContent } from '../../core/shared/NoContent.model';
 import { PaginationService } from '../../core/pagination/pagination.service';
 import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
+import { AsyncPipe, NgClass, NgForOf, NgIf } from '@angular/common';
+import { EPersonFormComponent } from './eperson-form/eperson-form.component';
+import { ThemedLoadingComponent } from '../../shared/loading/themed-loading.component';
+import { PaginationComponent } from '../../shared/pagination/pagination.component';
 
 @Component({
   selector: 'ds-epeople-registry',
   templateUrl: './epeople-registry.component.html',
+  imports: [
+    TranslateModule,
+    AsyncPipe,
+    NgIf,
+    EPersonFormComponent,
+    ReactiveFormsModule,
+    ThemedLoadingComponent,
+    PaginationComponent,
+    NgClass,
+    NgForOf
+  ],
+  standalone: true
 })
 /**
  * A component used for managing all existing epeople within the repository.

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts

@@ -31,6 +31,9 @@ import { PaginationServiceStub } from '../../../shared/testing/pagination-servic
 import { FindListOptions } from '../../../core/data/find-list-options.model';
 import { ValidateEmailNotTaken } from './validators/email-taken.validator';
 import { EpersonRegistrationService } from '../../../core/data/eperson-registration.service';
+import { ThemedLoadingComponent } from '../../../shared/loading/themed-loading.component';
+import { PaginationComponent } from '../../../shared/pagination/pagination.component';
+import { FormComponent } from '../../../shared/form/form.component';
 
 describe('EPersonFormComponent', () => {
   let component: EPersonFormComponent;
@@ -183,29 +186,31 @@ describe('EPersonFormComponent', () => {
 
     paginationService = new PaginationServiceStub();
     TestBed.configureTestingModule({
-      imports: [CommonModule, NgbModule, FormsModule, ReactiveFormsModule, BrowserModule,
+    imports: [CommonModule, NgbModule, FormsModule, ReactiveFormsModule, BrowserModule,
         TranslateModule.forRoot({
-          loader: {
-            provide: TranslateLoader,
-            useClass: TranslateLoaderMock
-          }
-        }),
-      ],
-      declarations: [EPersonFormComponent],
-      providers: [
+            loader: {
+                provide: TranslateLoader,
+                useClass: TranslateLoaderMock
+            }
+        }), EPersonFormComponent],
+    providers: [
         { provide: EPersonDataService, useValue: ePersonDataServiceStub },
         { provide: GroupDataService, useValue: groupsDataService },
         { provide: FormBuilderService, useValue: builderService },
         { provide: NotificationsService, useValue: new NotificationsServiceStub() },
         { provide: AuthService, useValue: authService },
         { provide: AuthorizationDataService, useValue: authorizationService },
         { provide: PaginationService, useValue: paginationService },
-        { provide: RequestService, useValue: jasmine.createSpyObj('requestService', ['removeByHrefSubstring'])},
+        { provide: RequestService, useValue: jasmine.createSpyObj('requestService', ['removeByHrefSubstring']) },
         { provide: EpersonRegistrationService, useValue: epersonRegistrationService },
         EPeopleRegistryComponent
-      ],
-      schemas: [NO_ERRORS_SCHEMA]
-    }).compileComponents();
+    ],
+    schemas: [NO_ERRORS_SCHEMA]
+})
+      .overrideComponent(EPersonFormComponent, {
+        remove: { imports: [    ThemedLoadingComponent, PaginationComponent,FormComponent]}
+      })
+      .compileComponents();
   }));
 
   epersonRegistrationService = jasmine.createSpyObj('epersonRegistrationService', {