Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #170

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

mechelon
Copy link
Member

@mechelon mechelon commented Feb 6, 2024

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

@mechelon mechelon merged commit 6a6ba49 into feature/retrieve-page-property-items Feb 6, 2024
2 checks passed
@mechelon mechelon deleted the analysis-9bYgao branch February 6, 2024 12:33
Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Improvements to Page.php
    The Page.php was adjusted for better readability and performance. It now handles empty results more gracefully, and the treatment of various property types has been refined.

  • Updates to UserCollection.php
    Changes to UserCollection.php involved cleaning up unnecessary comments and adjusting the handling of user data, now supporting a new 'people' type for users.

  • Refinement of Property.php
    The Property.php saw numerous improvements, primarily focused on enhancing readability. Checks have been added to ensure certain key data points ('id' and 'object') are present before proceeding. Also, the method dealing with content has been streamlined for early return, making it more efficient.

  • Clean up of RecordedEndpointPageTest.php
    In the RecordedEndpointPageTest.php, extraneous imports were removed leading to a leaner, cleaner codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants