Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oasis3 mct package.py #6

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Update oasis3 mct package.py #6

merged 7 commits into from
Mar 20, 2023

Conversation

harshula
Copy link
Collaborator

No description provided.

packages/oasis3-mct/package.py Outdated Show resolved Hide resolved
packages/oasis3-mct/package.py Outdated Show resolved Hide resolved
packages/oasis3-mct/package.py Outdated Show resolved Hide resolved
packages/oasis3-mct/package.py Outdated Show resolved Hide resolved
@harshula
Copy link
Collaborator Author

I'm going to drop the patch "oasis3-mct: add a nodebuginfo variant" for this PR and add a patch to point to "master" instead of "spack-build". I'm planning on using the variant name "deterministic" for builds that will be used to do a binary comparison.

@harshula
Copy link
Collaborator Author

Ready for review!

@harshula harshula marked this pull request as ready for review March 20, 2023 05:09
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the import everything looks good to go.

packages/oasis3-mct/package.py Outdated Show resolved Hide resolved
@harshula harshula merged commit ad9ecc2 into main Mar 20, 2023
harshula added a commit that referenced this pull request Mar 20, 2023
@harshula harshula deleted the oasis3-mct branch March 30, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants