Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nsys profile saved to local directory #1160

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

hengtaoguo
Copy link
Collaborator

@hengtaoguo hengtaoguo commented Jan 10, 2025

Description

Check whether the output_path is a GCS path or a local path:

  • For GCS path, check gsutil availability and if so save the profile.
  • For local path, save the profile using cp command.

FIXES: #911

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nsys profiler upload in all cases
1 participant