Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main #252

Merged
merged 11 commits into from
Oct 31, 2023
Merged

Main #252

merged 11 commits into from
Oct 31, 2023

Conversation

jim-smith
Copy link
Contributor

No description provided.

rpreen and others added 10 commits July 21, 2023 15:32
@jim-smith jim-smith requested a review from rpreen October 31, 2023 09:00
@rpreen
Copy link
Contributor

rpreen commented Oct 31, 2023

this is merging from main into development, which is the wrong way round

changes are supposed to go in development and then merged from development into main so it's streamlined

so this highlights again really why having a separate main branch is stupid because it creates unnecessary complications

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #252 (a83746e) into development (888cf63) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #252   +/-   ##
============================================
  Coverage        99.37%   99.37%           
============================================
  Files               41       41           
  Lines             5596     5596           
============================================
  Hits              5561     5561           
  Misses              35       35

@jim-smith jim-smith merged commit 8ace7c7 into development Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpreen rpreen rpreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jim-smith @rpreen