Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard locations if the LD_LIBRARY_PATH or ROOTSYS are empty #1378

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

andriish
Copy link

@andriish andriish commented Jan 6, 2025

BEGINRELEASENOTES

  • Use standard locations if the LD_LIBRARY_PATH or ROOTSYS are empty, i.e. /usr/lib,usr/lib64, etc.

ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor

Happy New Year to all!

@andresailer
Do you agree with these changes ?

@MarkusFrankATcernch
Copy link
Contributor

Hi @andriish ,

The puthon formatting check unfortunately failed:

Docker image ready for el9
####################################################################
###################### Executing user payload ######################
VVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVVV
RUNNING FLAKE8 CHECK
./DDCore/python/dd4hepFactories.py:33:14: E201 whitespace after '['
./DDCore/python/dd4hepFactories.py:33:117: E202 whitespace before ']'
./DDCore/python/dd4hep_base.py:38:35: E225 missing whitespace around operator
./DDCore/python/dd4hep_base.py:70:54: E225 missing whitespace around operator
./DDCore/python/dd4hep_base.py:71:56: E225 missing whitespace around operator
Error: Process completed with exit code 1.

Please fix.

@MarkusFrankATcernch
Copy link
Contributor

@andriish
Thanks for fixing. Let's see with Andre tomorrow, when he is back.

Copy link

github-actions bot commented Jan 6, 2025

Test Results

   14 files     14 suites   5h 34m 31s ⏱️
  369 tests   366 ✅ 0 💤 3 ❌
2 538 runs  2 529 ✅ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit 875c1fe.

♻️ This comment has been updated with latest results.

dd4hep = os.environ['DD4hepINSTALL']
else:
dd4hep = "/usr"
if os.getenv("ROOTSYS") is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd4hep = os.environ['DD4hepINSTALL']
inc = ' -I' + os.environ['ROOTSYS'] + '/include -I' + dd4hep + '/include '
lib = ' -L' + dd4hep + '/lib -lDDCore -lDDG4 -lDDSegmentation '
if os.getenv("DD4hepINSTALL") is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rootsys = os.environ['ROOTSYS']
else:
rootsys = "/usr"
sys.path.append(rootsys + os.sep + 'lib')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use os.path.join

@@ -156,9 +156,10 @@ namespace Gaudi {
const char sep = ':';
#endif
char* search_path = ::getenv( envVar );
if ( search_path ) {
if ( true ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Add a comment.

GaudiPluginService/src/PluginServiceV2.cpp Outdated Show resolved Hide resolved
GaudiPluginService/src/PluginServiceV1.cpp Outdated Show resolved Hide resolved
@@ -27,7 +27,10 @@ def __init__(self):
self.all_components = []

def scanPath(self):
ldp = os.environ['LD_LIBRARY_PATH'].split(':')
if os.getenv("LD_LIBRARY_PATH") is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants