Feat: check business registration number (#85)

* feat: install axios

* feat: check business registration number

* feat: add ODCLOUD api key for ci

.github/workflows/test.yaml

@@ -35,7 +35,8 @@ jobs:
       - name: start db & set .env
         run: |
           sudo service mysql start
-          echo DATABASE_URL=mysql://root:root@localhost:3306/db > .env
+          echo "DATABASE_URL=mysql://root:root@localhost:3306/db
+          ODCLOUD_API_KEY=${{ secrets.ODCLOUD_API_KEY }}" > .env
       - name: Install Dependencies & db setup
         run: |
           npm install

package.json

@@ -25,7 +25,7 @@
     "@sentry/node": "^7.73.0",
     "@sentry/profiling-node": "^1.2.1",
     "@types/jsonwebtoken": "^9.0.2",
-    "axios": "^1.6.0",
+    "axios": "^1.6.1",
     "crypto": "^1.0.1",
     "crypto-js": "^4.2.0",
     "dotenv": "^16.3.1",

prisma/seed.ts

@@ -5,7 +5,7 @@ async function main() {
   const user = await prisma.user.create({
     data: {
       id: 1,
-      businessRegistrationNumber: '0123456789',
+      businessRegistrationNumber: '5133001104',
       phoneNumber: '01012345678',
     },
   }); //user id 1

src/config/index.ts

@@ -24,6 +24,7 @@ class Config{
             NCP_SENS_ACCESS: process.env.NCP_SENS_ACCESS || '',
             NCP_SENS_MY_NUMBER: process.env.NCP_SENS_MY_NUMBER || '',
             NCP_SENS_ID: process.env.NCP_SENS_ID || '',
+            ODCLOUD_API_KEY: process.env.ODCLOUD_API_KEY || '',
         } as const;
     }
 

src/services/userService.ts

@@ -9,6 +9,7 @@ import {
   LoginToken,
 } from '@utils/jwt';
 import * as E from '@errors';
+import checkBusinessRegistrationNumber from '@utils/checkBusinessRegistrationNumber';
 
 const prisma = new PrismaClient();
 
@@ -78,6 +79,10 @@ export default {
       throw new E.UserAuthorizationError('토큰이 유효하지 않습니다.');
     }
 
+    if(!await checkBusinessRegistrationNumber(businessRegistrationNumber)){
+      throw new E.UserAuthorizationError('사업자 등록번호가 유효하지 않습니다.');
+    }
+
     let user = await prisma.user.findFirst({
       where: {
         businessRegistrationNumber: businessRegistrationNumber,

src/utils/checkBusinessRegistrationNumber.ts

@@ -0,0 +1,12 @@
+import axios from 'axios';
+import config from '@config';
+
+export default async (businessRegistrationNumber: string): Promise<boolean> => {
+    const { data } = await axios.post(
+        `https://api.odcloud.kr/api/nts-businessman/v1/status?serviceKey=${config.ODCLOUD_API_KEY}`,
+        {
+            b_no: [businessRegistrationNumber],
+        }
+    )
+    return data.data[0].b_stt_cd !== '';
+}

test/integration/seedValues.ts

@@ -1,6 +1,6 @@
 const user = {
   id: 1,
-  businessRegistrationNumber: '0123456789',
+  businessRegistrationNumber: '5133001104',
   phoneNumber: '01012345678',
 };
 

test/integration/storeService.test.ts

@@ -12,7 +12,7 @@ import { LoginToken } from '@utils/jwt';
 let app: FastifyInstance;
 
 const phone = '01011112222';
-const businessRegistrationNumber = '1122233444';
+const businessRegistrationNumber = '5133001104';
 let accessToken: string;
 
 beforeAll(async () => {

test/integration/userService.test.ts

@@ -16,7 +16,7 @@ afterAll(async () => {
 });
 
 const phone = '01012345678';
-const businessRegistrationNumber = '1234567890';
+const businessRegistrationNumber = '5133001104';
 let tokenForCertificatePhone: string;
 let certificatedPhoneToken: string;
 let accessToken: string;

test/unit/businessNumber.test.ts

@@ -0,0 +1,9 @@
+import checkBusinessRegistrationNumber from "@utils/checkBusinessRegistrationNumber";
+import * as E from "@errors";
+import { test, expect } from "@jest/globals";
+
+test("checkBusinessRegistrationNumber", async () => {
+    expect(await checkBusinessRegistrationNumber("5133001104")).toBe(true);
+    expect(await checkBusinessRegistrationNumber("")).toBe(false);
+    expect(await checkBusinessRegistrationNumber("1234567890")).toBe(false);
+});