New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert rfface to C++ #2636

Merged

zingale merged 1 commit into AMReX-Astro:development from maxpkatz:cxx_rfface

Oct 15, 2023

Member

maxpkatz commented Oct 15, 2023

PR summary

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          Convert rfface to C++

maxpkatz marked this pull request as ready for review

October 15, 2023 19:14

Member Author

maxpkatz commented Oct 15, 2023

Radiation tests pass: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-15/index.html

zingale approved these changes

View reviewed changes

zingale merged commit 466e5a5 into AMReX-Astro:development

maxpkatz deleted the cxx_rfface branch

October 15, 2023 19:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet