Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have print_source_change take a vector by reference #2832

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 26, 2024

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, we can also make this const

@zingale
Copy link
Member Author

zingale commented Apr 26, 2024

done

@zingale zingale merged commit f58f11c into AMReX-Astro:development Apr 26, 2024
25 checks passed
@zingale zingale deleted the use_ref_print_source_change branch April 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants