enable more clang-tidy checks (#1525)

also modernize typedefs
AMReX-Astro · Mar 27, 2024 · 3112c13 · 3112c13
1 parent f47a7fc
commit 3112c13
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -11,7 +11,6 @@ Checks: >
        -cppcoreguidelines-init-variables,
        -cppcoreguidelines-interfaces-global-init,
        -cppcoreguidelines-macro-usage,
-       -cppcoreguidelines-no-malloc,
        -cppcoreguidelines-non-private-member-variables-in-classes,
        -cppcoreguidelines-owning-memory,
        -cppcoreguidelines-pro-*,
@@ -24,7 +23,6 @@ Checks: >
      modernize-*,
        -modernize-avoid-c-arrays,
        -modernize-use-trailing-return-type,
-       -modernize-use-using,
      performance-*,
        -performance-avoid-endl,
      portability-*,

diff --git a/integration/integrator_data.H b/integration/integrator_data.H
@@ -45,8 +45,8 @@ constexpr int integrator_neqs ()
     return int_neqs;
 }
 
-typedef amrex::Array1D<short, 1, INT_NEQS> IArray1D;
-typedef amrex::Array1D<amrex::Real, 1, INT_NEQS> RArray1D;
-typedef ArrayUtil::MathArray2D<1, INT_NEQS, 1, INT_NEQS> RArray2D;
+using IArray1D = amrex::Array1D<short, 1, INT_NEQS>;
+using RArray1D = amrex::Array1D<amrex::Real, 1, INT_NEQS>;
+using RArray2D = ArrayUtil::MathArray2D<1, INT_NEQS, 1, INT_NEQS>;
 
 #endif
diff --git a/interfaces/burn_type.H b/interfaces/burn_type.H
@@ -32,7 +32,7 @@ const int net_ienuc = NumSpec + 1;
 
 // this is the data type that is used to get the ydots from the actual
 // RHS of the network, regardless of Strang or SDC
-typedef amrex::Array1D<amrex::Real, 1, neqs> YdotNetArray1D;
+using YdotNetArray1D = amrex::Array1D<amrex::Real, 1, neqs>;
 
 // these indices represent the order that the conserved state comes
 // into the ODE integration from the hydro code.
@@ -58,7 +58,7 @@ const int SVAR_EVOLVE = SFX;
 // this is the data type of the dense Jacobian that the network wants.
 // it is not the same size as the Jacobian that VODE cares about when
 // we are doing simplified-SDC
-typedef ArrayUtil::MathArray2D<1, neqs, 1, neqs> JacNetArray2D;
+using  JacNetArray2D = ArrayUtil::MathArray2D<1, neqs, 1, neqs>;
 
 struct burn_t
 {