Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update networks, benchmarks, and NSE_index due to specie name capitalization #1362

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

zhichen3
Copy link
Collaborator

corresponding update due to pynucastro/pynucastro#652

@zingale
Copy link
Member

zingale commented Oct 23, 2023

did we expect test_rhs to fail?

@zhichen3
Copy link
Collaborator Author

zhichen3 commented Oct 23, 2023

did we expect test_rhs to fail?

test_rhs (ecsn) result changed probably because we updated the neutrino loss procedure for weak rates pynucastro/pynucastro#655

@zingale
Copy link
Member

zingale commented Oct 23, 2023

okay, let me regen that net and update the benchmark in a separate PR

@zhichen3
Copy link
Collaborator Author

accidentally deleted a whitespace during merge

@zingale zingale merged commit 7974a0d into AMReX-Astro:development Oct 23, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants