Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert reinterpret_cast in linalg.H #1412

Merged
merged 2 commits into from
Dec 18, 2023
Merged

revert reinterpret_cast in linalg.H #1412

merged 2 commits into from
Dec 18, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Dec 17, 2023

This reverts commit 1f0c666.

This is an alternative to #1409 and seems to work better on frontier

@yut23 yut23 mentioned this pull request Dec 18, 2023
Closed
@zingale
Copy link
Member Author

zingale commented Dec 18, 2023

all tests pass:
http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2023-12-18-001/index.html

@zingale zingale merged commit 01577f3 into AMReX-Astro:development Dec 18, 2023
24 checks passed
@zingale zingale deleted the new_revert_linalg branch December 18, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWibking BenWibking BenWibking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zingale @BenWibking @maxpkatz