Avoid dividing by zero in constexpr linear algebra routines #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the crash in `Detonation-collision-retry-SDC` in the Castro test suite.
yut23
added a commit
to yut23/Castro
that referenced
this pull request
Jul 6, 2024
5 tasks
|
we'll have to do a separate Castro PR to add the info to the true SDC stuff |
zingale
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHS::dgefa()now stops if the matrix is singular, and returns an integer that works the same as theinfoparameter for the routine inlinpack.H. If the LU decomposition fails, it is the index of the row that failed, and is zero if the decomposition succeeded.This fixes the crash in
Detonation-collision-retry-SDCin the Castro test suite. The benchmark does need to be updated, since it now stops at step 10 instead of 11, and the plotfile for that step was last updated before we changed the setup in AMReX-Astro/Castro#2806.