New Soil temperature tidy up #9283
Conversation
… There is an issue with some of the simulations not running with some odd errors. Reassess after the other fixes are in.
…to SoilTemperature # Conflicts: # Tests/UnderReview/SoilTemperature/SoilTemperature.apsimx
…ons and arrays, also mke them and fraction as private
…to SoilTemperature
…some that have APSIM equivalent (e.g. Divide)
…to SoilTemperature # Conflicts: # Models/Soils/SoilTemp/SoilTemperature.cs
…y tags,deleting sumRange
|
The stats are slightly different for the NZ simulation. This is because the weather data has values for wind speed, while the others don't (thus default is always used). As the diffs are small and reading the wind speed from weather data is the right thing to do, these changes can be accepted, and this Pull Request can be merged |
…l profile and surface temperature (Average, Minimum and Maximum)
| /// <summary>Average soil temperature for each layer (oC)</summary> | ||
| public double[] MaximumSoilTemperature { get { return st; } } | ||
|
|
||
| /// <summary>Average soil temperature for soil surface (oC)</summary> |
There was a problem hiding this comment.
Daily maximum soil temperature
| /// <summary>Average soil temperature for soil surface (oC)</summary> | ||
| public double AverageSoilSurfaceTemperature { get { return double.NaN; } } | ||
|
|
||
| /// <summary>Average soil temperature for each layer (oC)</summary> |
There was a problem hiding this comment.
Daily minimum soil temperature
There was a problem hiding this comment.
We thought about using the term "Daily" in the name, but it would make it long, and Dean remarks that all variables in APSIM are on a daily basis... I will correct the info in the summary tag in the next commit...
working on #4080
Several changes to tidy up the code (in general and to make integration with Crop2ML easier)