Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Hotfix/#272 ] 시간 배열의 0번째는 시간표에 우선순위 적용안되는 이슈 해결 #273

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[ Hotfix/#272 ] 시간 배열의 0번째는 시간표에 우선순위 적용안되는 이슈 해결 #273

merged 2 commits into from
Jul 18, 2024

Conversation

ljh0608
Copy link
Member

@ljh0608 ljh0608 commented Jul 18, 2024 •
edited
Loading

🌀 해당 이슈 번호

🔹 어떤 것을 변경했나요?

  • selectedEntryId가 0일 때 즉 시간 배열의 첫번째는 우선순위가 뷰에 적용안되던 이슈를 해결

🔹 어떻게 구현했나요?

        const priority = selectedEntryId ? selectedSlots[selectedEntryId].priority : 0;

위로직은 id가 0일 때, 즉 첫번째 원소일때도 falsy한값이므로 무조건 0으로 반환하기에 null임을 체크해주었습니다.

 const priority = selectedEntryId !== null ? selectedSlots[selectedEntryId].priority : 0;

🔹 PR 포인트를 알려주세요!

구현방식에 언급하였습니다!

🔹 스크린샷을 남겨주세요!

2024-07-18.5.30.39.mov

@ljh0608 ljh0608 added the hotfix hotfix branch label Jul 18, 2024
@ljh0608 ljh0608 requested a review from simeunseo July 18, 2024 08:36
@ljh0608 ljh0608 self-assigned this Jul 18, 2024
@github-actions github-actions bot added size/XS and removed size/S labels Jul 18, 2024
@ljh0608 ljh0608 merged commit 44e9a30 into main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeunseo simeunseo Awaiting requested review from simeunseo

Assignees

@ljh0608 ljh0608

Labels
hotfix hotfix branch size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Hotfix ] 우선순위 선택에서 timeSlot 색상이 변하지 않는 오류 수정
1 participant
@ljh0608