-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix/#320] 자잘한 스타일링, 라이팅 변경 #327
Merged
Merged
Changes from 17 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
179b035
fix: bottomsheet border-radius 변경
simeunseo 3984e64
fix: 회의정보입력 -> 회의 정보 입력
simeunseo 2bdced4
fix: 상단 회의 정보 안내 문구 디자인 변경
simeunseo d960a1a
fix: 탭투탭 그라데이션 제거
simeunseo fb0d406
fix: 드롭다운 목록 높이 조정
simeunseo 2c99b83
fix: 관리자 페이지 -> 방장 페이지로 라이팅 변경
simeunseo 4b3a631
fix: 바텀시트 마진 변경
simeunseo 8634388
fix: 약속 생성하기 -> 회의 일정 정하기로 라이팅 변경
simeunseo bcf5397
fix: 회의 장소 유무에 따라 온보딩 로띠 위치 달라지도록 조건부 처리
simeunseo 7b4be4e
Merge branch 'develop' into fix/#320/CSS
simeunseo 6b8c73c
fix: 온보딩 로띠 top 값 수정
simeunseo 53b2b13
Merge branch 'fix/#320/CSS' of https://github.com/ASAP-as-soon-as-pos…
simeunseo ee9c860
fix: 온보딩 로띠 top 값 수정
simeunseo 307c7aa
Merge branch 'fix/#318/NameValidation' into fix/#320/CSS
simeunseo f0e035e
fix: 방장 비밀번호 8자 초과하는 케이스 에러로 분류하지 않고 허용하도록 변경
simeunseo db6ada5
Merge branch 'develop' into fix/#320/CSS
ljh0608 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,6 @@ export { | |
RadioCheckIc, | ||
SpeechBubbleIc, | ||
TimeIc, | ||
TooltipArrowIc, | ||
Wave, | ||
TooltipArrowIc, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,11 +22,7 @@ function SetHostInfo({ meetingInfo, setMeetingInfo, setStep }: FunnelProps) { | |
|
||
const passWordOnChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
setMeetingInfo((prev: MeetingInfo) => { | ||
if (e.target.value.length < 9) { | ||
return { ...prev, password: e.target.value }; | ||
} | ||
alert('비밀번호는 8자리 이하로 말해주세요'); | ||
return { ...prev }; | ||
return { ...prev, password: e.target.value }; | ||
}); | ||
}; | ||
|
||
|
@@ -44,6 +40,7 @@ function SetHostInfo({ meetingInfo, setMeetingInfo, setStep }: FunnelProps) { | |
} | ||
}; | ||
|
||
console.log(meetingInfo.password.length); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. p3) console 이 자주 올라오진 않지만! eslint 옵션중 console 에러로 인식하도록 변경하는거 어떠신가요?? 이 부분 이번주 회의 때 얘기해보면 좋겠습니다! |
||
return ( | ||
<SetHostInfoWrapper> | ||
<HostInfoSection> | ||
|
@@ -55,6 +52,7 @@ function SetHostInfo({ meetingInfo, setMeetingInfo, setStep }: FunnelProps) { | |
value={meetingInfo.name} | ||
setValue={hostOnChange} | ||
resetValue={resetHost} | ||
max={6} | ||
placeholder={'방장 이름'} | ||
/> | ||
</HostNameSection> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3) input의 최대 길이를 나타내는 props가 맞다면 maxLength 네이밍을 고려해보셔도 좋을 것 같습니다!