Guess download URL #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lsanwick
added a commit
to lsanwick/asdf-jq
that referenced
this pull request
Jun 1, 2023
iGEL
pushed a commit
to pitch-io/asdf-jq
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running asdf at scale. This can lead to throttling on the call to api.github.com to fetch release information—even with an API token.
We're looking to run asdf less often, but nonetheless, we've found that the call to api.github.com can actually be avoided in most cases. After all, it's only used to get the URL to the release binary, and that one uses a predictable format for recent versions.
As such, this patch eagerly tries to predict the download URL, and falls back to the API approach if that doesn't work. With most installs, this should be faster and cheaper.