Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be 3659 CVE 2007 4559 iiii #68

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

rickprice
Copy link

@rickprice rickprice commented Jan 7, 2025

Changes for CVE-2007-4559

@rickprice rickprice force-pushed the BE-3659-cve-2007-4559-IIII branch from 6cf9854 to 9c778f8 Compare January 7, 2025 15:18
@rickprice rickprice requested a review from icanhasmath January 7, 2025 15:20
@icanhasmath icanhasmath requested a review from ucodery January 7, 2025 16:42
@rickprice rickprice force-pushed the BE-3659-cve-2007-4559-IIII branch from 9c778f8 to 738cba1 Compare January 7, 2025 16:51
Lib/tarfile.py Outdated Show resolved Hide resolved
Lib/test/test_tarfile.py Outdated Show resolved Hide resolved
Lib/test/test_tarfile.py Outdated Show resolved Hide resolved
Makefile.pre.in Outdated Show resolved Hide resolved
@rickprice rickprice force-pushed the BE-3659-cve-2007-4559-IIII branch 4 times, most recently from 490661d to a2c11e4 Compare January 8, 2025 18:18
Copy link

@ucodery ucodery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will need a News entry. In addition to the CVE fix, the change in TarFile and ExFileObject API should be noted

0o10000000)
self.assertEqual(tarfile.nti(b"\x80\x00\x00\x00\xff\xff\xff\xff"),
0xffffffff)
# self.assertEqual(tarfile.nti(b"\xff\xff\xff\xff\xff\xff\xff\xff"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for not running all these checks?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are for unsupported header types

@rickprice rickprice force-pushed the BE-3659-cve-2007-4559-IIII branch from fb8811b to 659de44 Compare January 20, 2025 23:31
@rickprice rickprice force-pushed the BE-3659-cve-2007-4559-IIII branch from 659de44 to 4801727 Compare January 20, 2025 23:33
@rickprice rickprice requested a review from ucodery January 20, 2025 23:58
@icanhasmath icanhasmath merged commit 0220b82 into 2.7.18.x Jan 21, 2025
@icanhasmath icanhasmath deleted the BE-3659-cve-2007-4559-IIII branch January 21, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants