test(SFI-1025): fix unit tests

Adyen · Dec 18, 2024 · 14d8cf1 · 14d8cf1
1 parent d5f6baf
commit 14d8cf1
Show file tree

Hide file tree

Showing 7 changed files with 81 additions and 87 deletions.
diff --git a/jest/sfccCartridgeMocks.js b/jest/sfccCartridgeMocks.js
@@ -308,6 +308,20 @@ jest.mock(
       action: { type: 'mockedAction' },
     })),
     createRedirectUrl: jest.fn(() => 'mocked_RedirectUrl'),
+    getService: jest.fn(() => ({
+      getURL: jest.fn(() => 'mocked_service_url'),
+      setURL: jest.fn(),
+      addHeader: jest.fn(),
+      call: jest.fn(() => ({
+        status: 'success',
+        isOk: jest.fn(() => true),
+        object: {
+          getText: jest.fn(() =>
+            '{"data":"mocked api response"}'),
+
+        },
+      }))
+    }))
   }),
   { virtual: true },
 );
@@ -320,6 +334,7 @@ jest.mock(
     getCreditCardInstallments: jest.fn(() => true),
     getAdyenTokenisationEnabled: jest.fn(() => true),
     getAdyenClientKey: jest.fn(() => 'mocked_client_key'),
+    getAdyenApiKey: jest.fn(() => 'mocked_api_key'),
     getGoogleMerchantID: jest.fn(() => 'mocked_google_merchant_id'),
     getAdyenCardholderNameEnabled: jest.fn(() => true),
     getAdyenPayPalIntent: jest.fn(() => 'mocked_intent'),
@@ -396,27 +411,6 @@ jest.mock(
   { virtual: true },
 );
 
-jest.mock(
-  '*/cartridge/adyen/utils/lineItemHelper',
-  () => ({
-    getDescription: jest.fn((lineItem) => lineItem.productName),
-    getId: jest.fn((lineItem) => lineItem.productID),
-    getQuantity: jest.fn((lineItem) => lineItem.quantityValue),
-    getItemAmount: jest.fn((lineItem) => ({
-      divide: jest.fn((quantity) => ({
-        getValue: jest.fn(() => lineItem.adjustedNetPrice / quantity),
-      })),
-    })),
-    getVatAmount: jest.fn((lineItem) => ({
-      divide: jest.fn((quantity) => ({
-        getValue: jest.fn(() => lineItem.getAdjustedTax / quantity),
-      })),
-    })),
-    getAllLineItems: jest.fn((lineItem) => lineItem),
-  }),
-  { virtual: true },
-);
-
 jest.mock(
   '*/cartridge/adyen/utils/paypalHelper',
   () => ({
@@ -479,3 +473,14 @@ jest.mock(
   }),
   { virtual: true },
 );
+
+jest.mock(
+  '*/cartridge/adyen/logs/adyenCustomLogs',
+  () => ({
+    fatal_log: jest.fn(),
+    error_log: jest.fn(),
+    debug_log: jest.fn(),
+    info_log: jest.fn(),
+  }),
+  { virtual: true },
+);
diff --git a/src/cartridges/int_adyen_SFRA/cartridge/adyen/analytics/__tests__/analyticsService.test.js b/src/cartridges/int_adyen_SFRA/cartridge/adyen/analytics/__tests__/analyticsService.test.js
@@ -1,66 +1,55 @@
+const AdyenHelper = require('*/cartridge/adyen/utils/adyenHelper');
+const AdyenLogs = require('*/cartridge/adyen/logs/adyenCustomLogs');
 const { createCheckoutAttemptId } = require('../analyticsService');
 
-const AdyenHelper = {
-  getApplicationInfo: jest.fn(),
-};
-
-const execute = jest.fn();
-const constants = {
-  SERVICE: {
-    ADYEN_ANALYTICS: 'ADYEN_ANALYTICS',
-  },
-};
-
-const AdyenLogs = {
-  error_log: jest.fn(),
-};
-
-global.AdyenHelper = AdyenHelper;
-global.execute = execute;
-global.constants = constants;
-global.AdyenLogs = AdyenLogs;
-
 describe('createCheckoutAttemptId', () => {
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
   it('should return checkoutAttemptId when the execute function is successful', () => {
     const mockCheckoutAttemptId = 'test-checkout-attempt-id';
-    const mockApplicationInfo = { name: 'testApp' };
-
-    AdyenHelper.getApplicationInfo.mockReturnValue(mockApplicationInfo);
-    execute.mockReturnValue({ checkoutAttemptId: mockCheckoutAttemptId });
+    AdyenHelper.getService.mockImplementationOnce(() => ({
+      getURL: jest.fn(() => 'mocked_service_url'),
+      setURL: jest.fn(),
+      addHeader: jest.fn(),
+      call: jest.fn(() => ({
+        status: '200',
+        isOk: jest.fn(() => true),
+        object: {
+          getText: jest.fn(() =>
+            `{"checkoutAttemptId":"${mockCheckoutAttemptId}"}`),
+
+        },
+      }))
+    }));
 
     const result = createCheckoutAttemptId();
-
-    setTimeout(() => {
-      expect(AdyenHelper.getApplicationInfo).toHaveBeenCalled();
-      expect(execute).toHaveBeenCalledWith(constants.SERVICE.ADYEN_ANALYTICS, {
-        applicationInfo: mockApplicationInfo,
-        channel: 'Web',
-        platform: 'Web',
-      });
-      expect(result).toEqual({ data: mockCheckoutAttemptId });
-    }, 0)
+    expect(result).toEqual({ data: mockCheckoutAttemptId });
   });
 
   it('should return an error object and log error when execute throws an error', () => {
-    const mockError = new Error('Execution failed');
-    AdyenHelper.getApplicationInfo.mockReturnValue({});
-    execute.mockImplementation(() => {
-      throw mockError;
-    });
-
+    AdyenHelper.getService.mockImplementationOnce(() => ({
+      getURL: jest.fn(() => 'mocked_service_url'),
+      setURL: jest.fn(),
+      addHeader: jest.fn(),
+      call: jest.fn(() => ({
+        status: 'failed',
+        isOk: jest.fn(() => false),
+        getError: jest.fn(() => ({
+          toString: jest.fn(() => '500')
+        })),
+        getStatus: jest.fn(() => 'failed'),
+        getErrorMessage: jest.fn(() => 'Service error'),
+        getMsg: jest.fn(() => 'Service error'),
+      }))
+    }));
+    const mockError = new Error('AdyenAnalytics service call error code 500 Error => ResponseStatus: failed | ResponseErrorText: Service error | ResponseText: Service error');
     const result = createCheckoutAttemptId();
 
-    setTimeout(() => {
-      expect(AdyenHelper.getApplicationInfo).toHaveBeenCalled();
       expect(AdyenLogs.error_log).toHaveBeenCalledWith(
-        'createCheckoutAttemptId for /analytics call failed:',
-        mockError
+        'createCheckoutAttemptId for /analytics call failed:', mockError
       );
       expect(result).toEqual({ error: true });
-    }, 0)
   });
-});
+});
diff --git a/src/cartridges/int_adyen_SFRA/cartridge/adyen/analytics/analyticsService.js b/src/cartridges/int_adyen_SFRA/cartridge/adyen/analytics/analyticsService.js
@@ -26,7 +26,7 @@ function execute(serviceType, requestObject, checkoutAttemptID = '') {
   const callResult = service.call(JSON.stringify(requestObject));
   if (!callResult.isOk()) {
     throw new Error(
-      `${serviceType} service call error code${callResult
+      `${serviceType} service call error code ${callResult
         .getError()
         .toString()} Error => ResponseStatus: ${callResult.getStatus()} | ResponseErrorText: ${callResult.getErrorMessage()} | ResponseText: ${callResult.getMsg()}`,
     );

diff --git a/src/cartridges/int_adyen_SFRA/cartridge/adyen/logs/adyenError.js b/src/cartridges/int_adyen_SFRA/cartridge/adyen/logs/adyenError.js
@@ -1,11 +1,14 @@
-/* eslint-disable max-classes-per-file */
-class AdyenError extends Error {
-  constructor(message, cause) {
-    super(message);
-    this.cause = cause;
-    this.name = this.constructor.name;
+function AdyenError(message) {
+  this.message = message || 'Something went wrong!';
+  this.name = this.constructor.name;
+  const error = new Error(this.message);
+  this.stack = error.stack;
+  if (Error.captureStackTrace) {
+    Error.captureStackTrace(this, AdyenError);
   }
 }
+AdyenError.prototype = Object.create(Error.prototype);
+AdyenError.prototype.constructor = AdyenError;
 
 module.exports = {
   AdyenError,

diff --git a/...yen_SFRA/cartridge/adyen/scripts/expressPayments/paypal/__tests__/saveShopperData.test.js b/...yen_SFRA/cartridge/adyen/scripts/expressPayments/paypal/__tests__/saveShopperData.test.js
@@ -19,7 +19,6 @@ beforeEach(() => {
     json: jest.fn(),
     setStatusCode: jest.fn(),
   };
-  AdyenLogs.error_log = jest.fn();
 });
 
 afterEach(() => {
@@ -34,8 +33,8 @@ describe('Save Shopper controller', () => {
     expect(next).toHaveBeenCalled();
   });
 
-  xit('Should return response when Save Shopper call is not successful', () => {
-    res.json = jest.fn(() => {throw new Error('unexpected mock error')});
+  it('Should return response when Save Shopper call is not successful', () => {
+    res.json.mockImplementationOnce(() => {throw new Error('unexpected mock error')});
     saveShopperData(req, res, next);
     expect(AdyenLogs.error_log).toHaveBeenCalledTimes(1);
     expect(URLUtils.url).toHaveBeenCalledWith('Error-ErrorCode', 'err', 'general');

diff --git a/...artridge/adyen/scripts/hooks/payment/processor/middlewares/__tests__/posAuthorize.test.js b/...artridge/adyen/scripts/hooks/payment/processor/middlewares/__tests__/posAuthorize.test.js
@@ -3,16 +3,16 @@ let posAuthorize;
 let orderNumber;
 let paymentInstrument;
 let paymentProcessor;
-let Logger;
+let AdyenLogs
 
 beforeEach(() => {
+  AdyenLogs = require('*/cartridge/adyen/logs/adyenCustomLogs');
   posAuthorize = require('../posAuthorize');
   orderNumber = 'mockedNum';
   paymentInstrument = {
     paymentTransaction: {},
   };
   paymentProcessor = 'mockedPaymentProcessor';
-  Logger = require('dw/system/Logger');
   jest.clearAllMocks();
 });
 
@@ -35,7 +35,7 @@ describe('POS Authorize', () => {
       paymentProcessor,
     );
     expect(authorizeResult).toMatchSnapshot();
-    expect(Logger.fatal.mock.calls.length).toBe(1);
+    expect(AdyenLogs.fatal_log).toHaveBeenCalled();
   });
 
   it('should return error if createTerminalPayment fails', () => {
@@ -51,7 +51,7 @@ describe('POS Authorize', () => {
       paymentInstrument,
       paymentProcessor,
     );
-    expect(Logger.fatal.mock.calls.length).toBe(1);
+    expect(AdyenLogs.fatal_log).toHaveBeenCalled();
     expect(authorizeResult).toMatchSnapshot();
   });
 

diff --git a/...t_adyen_SFRA/cartridge/adyen/scripts/payments/__tests__/getCheckoutPaymentMethods.test.js b/...t_adyen_SFRA/cartridge/adyen/scripts/payments/__tests__/getCheckoutPaymentMethods.test.js
@@ -1,11 +1,12 @@
 /* eslint-disable global-require */
 const BasketMgr = require('dw/order/BasketMgr');
+const AdyenLogs = require('*/cartridge/adyen/logs/adyenCustomLogs');
 const getCheckoutPaymentMethods = require('*/cartridge/adyen/scripts/payments/getCheckoutPaymentMethods');
 const getPaymentMethods = require('*/cartridge/adyen/scripts/payments/adyenGetPaymentMethods');
 let req;
 let res;
 let next;
-let Logger;
+
 beforeEach(() => {
    req = {
       locale: {
@@ -16,7 +17,6 @@ beforeEach(() => {
       json: jest.fn(),
    };
    next = jest.fn();
-   Logger = require('dw/system/Logger');
 });
 
 afterEach(() => {
@@ -76,14 +76,12 @@ describe('getCheckoutPaymentMethods', () => {
    });
 
    it('does not return AdyenPaymentMethods', () => {
-      getPaymentMethods.getMethods = jest.fn(
-         new Logger.error('error'),
-      );
+      getPaymentMethods.getMethods.mockImplementationOnce(() => {throw new Error('mock error')});
       getCheckoutPaymentMethods(req, res, next);
       expect(res.json).toHaveBeenCalledWith({
          error: true,
        });
-      expect(Logger.fatal.mock.calls.length).toBe(1);
+      expect(AdyenLogs.fatal_log).toHaveBeenCalled();
       expect(next).toHaveBeenCalled();
    });
 });