Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhirpy client example #4

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fhirpy client example #4

wants to merge 11 commits into from

Conversation

krvital
Copy link

@krvital krvital commented Dec 6, 2024

No description provided.

aidbox-with-python-sdk/README.md Outdated Show resolved Hide resolved
aidbox-with-python-sdk/README.md Outdated Show resolved Hide resolved
aidbox-with-python-sdk/fhirpy_custom_models.py Outdated Show resolved Hide resolved
#### Installation

``` shell
poetry add [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we need to explain how to generate dataclasses. Ideally, it will be nice to have similar structure for that and next section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I got it right you mean generating data models with fhirpy-types. But the idea here is that you do not have to generate them manually, since there are pre-baked packages in PyPi.

aidbox-with-python-sdk/README.md Outdated Show resolved Hide resolved
aidbox-with-python-sdk/README.md Outdated Show resolved Hide resolved
aidbox-with-python-sdk/README.md Show resolved Hide resolved
aidbox-with-python-sdk/README.md Outdated Show resolved Hide resolved
aidbox-with-python-sdk/README.md Outdated Show resolved Hide resolved

```sh
# generate FHIR data models
fscg generate --generator python --output generated --package hl7.fhir.r4.core:4.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also generate classes for our custom resources? E.g. AidboxSubscriptionTopic?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean extending example with custom resources to highlight the advantages of the fhir-schema-codegen over the fhirpy-types package? I think it's mainly a question for fhir-schema-codegen. We could add this later, as soon as it becomes possible to generate custom resources from Aidbox instance.

The same applies to other features: I propose enhancing this example gradually, in line with the evolution of fhir-schema-codegen.

@krvital krvital marked this pull request as ready for review January 14, 2025 13:03
@krvital krvital requested a review from ryukzak January 14, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants