-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fhirpy client example #4
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Aleksandr Penskoi <[email protected]>
#### Installation | ||
|
||
``` shell | ||
poetry add [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we need to explain how to generate dataclasses. Ideally, it will be nice to have similar structure for that and next section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I got it right you mean generating data models with fhirpy-types
. But the idea here is that you do not have to generate them manually, since there are pre-baked packages in PyPi.
|
||
```sh | ||
# generate FHIR data models | ||
fscg generate --generator python --output generated --package hl7.fhir.r4.core:4.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also generate classes for our custom resources? E.g. AidboxSubscriptionTopic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean extending example with custom resources to highlight the advantages of the fhir-schema-codegen
over the fhirpy-types
package? I think it's mainly a question for fhir-schema-codegen
. We could add this later, as soon as it becomes possible to generate custom resources from Aidbox instance.
The same applies to other features: I propose enhancing this example gradually, in line with the evolution of fhir-schema-codegen
.
Co-authored-by: Aleksandr Penskoi <[email protected]>
No description provided.