-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix POV Display usermod #4427
base: main
Are you sure you want to change the base?
fix POV Display usermod #4427
Conversation
did not try to compile, but generally looks ok to me. |
3402a05
to
001b882
Compare
@Liliputech please do not force-push while you have a PR open for the the main WLED repo. It causes lots of crazy side-effects like lost review comments, auto-closed bug reports and broken links to code authors.
|
@Liliputech I think the usermod needs some more fixing and improvements.
Btw, do you know who is "Arthur Suzuki"? he appears as the author of initial commit, but does not have a github account. He has directly committed the usermod into the Aircoookie repo, so he must be a maintainer? or maybe just a hacker who abused a security flaw in github? |
Hi @softhack007 Thank you for your feedback :)
Maybe I should try to fix that by updating my code to fit the new version of PNGDEC instead then.
Sure! And a couple pictures!
Glad you liked it :)
Got to fix this indeed.
It is intended for 1D strip, the idea is to have an imaged displayed on a rotating strip.
Unfortunately there is not much to be done here if you want to properly decode PNG.
I am Arthur :) you can find the information elsewhere by searching for my nickname or profile picture ;) |
@Liliputech Since you are fixing things might be consider adding a readme as it is strange the usermod even got merged without one |
Actually I'm thinking about re-using the routines provided by the "image_loader.cpp" file provided by the GIF decoder effect. That would make a lot more sense :) |
001b882
to
ce44827
Compare
There was a compile issue when trying to enable POV Image effect.
This small PR fixes the problem.