refactor: remove int inheritance from Version #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-remove-int-inheritance-from-version
branch
from
6136242 to
e1e34d3
Compare
nosahama
reviewed
Jun 6, 2024
nosahama
previously approved these changes
Jun 6, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-remove-int-inheritance-from-version
branch
from
e1e34d3 to
3bdd4ae
Compare
aiven-anton
reviewed
Jun 7, 2024
aiven-anton
reviewed
Jun 7, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-remove-int-inheritance-from-version
branch
from
3bdd4ae to
b4064ed
Compare
nosahama
approved these changes
Jun 7, 2024
keejon
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Make Version a container class for integer for stronger typing.