Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: Fix typo in constraints dependencies #619

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

RommelLayco
Copy link
Contributor

@RommelLayco RommelLayco commented Mar 26, 2024

About this change - What it does

Fixes typo of constraints dependencies in the pyproject.toml

@RommelLayco RommelLayco requested a review from a team March 26, 2024 21:21
carteranz
carteranz previously approved these changes Mar 26, 2024
@RommelLayco RommelLayco force-pushed the RommelLayco-fix-typo branch from 570a01b to af134c9 Compare March 26, 2024 21:35
@RommelLayco RommelLayco force-pushed the RommelLayco-fix-typo branch 2 times, most recently from 7309076 to 41cb24b Compare March 27, 2024 01:09
@@ -127,7 +127,7 @@ contraints = [
"PyYAML==6.0",
"requests==2.28.2",
"responses==0.23.1",
"rohmu==1.0.10",
"rohmu==2.3.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we bumping this version as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to update this and other versions as they failed to download during ci

@RommelLayco RommelLayco force-pushed the RommelLayco-fix-typo branch from 41cb24b to a096913 Compare March 27, 2024 08:01
Update constraints to use latest versions.
@RommelLayco RommelLayco force-pushed the RommelLayco-fix-typo branch from a096913 to 8e3a85e Compare March 27, 2024 08:08
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (097fb29) to head (8e3a85e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   90.90%   90.86%   -0.05%     
==========================================
  Files          31       31              
  Lines        4917     4917              
==========================================
- Hits         4470     4468       -2     
- Misses        447      449       +2     

see 4 files with indirect coverage changes

@Aiqin-Aiven Aiqin-Aiven merged commit 5505b86 into Aiven-Open:main Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants