This repository has been archived by the owner on May 18, 2020. It is now read-only.
Use plain files instead of zip for crypto blobs #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes done in #4 as it doesn't seem to scale for larger number of blobs.
However it makes a small change which should remove problems with viewing/managing crypto folder: now files are expected to be in folders based on first bytes of the hash, i.e:
crypto/AABBCC01234567890AABBCC01234567890.bin
will now be stored in
crypto/AA/BB/CC/01234567890AABBCC01234567890.bin
There is a helper script in orbital repo to rearrange files from plain structure to this one.
From the current dump, there should be at most 2 files in one folder with 3 "levels".
There seem to be some overhead (I guess it depends on underlying fs) due to many small files: with latest dump zip folder is 1.2G while on ext4 unpacked files occupy 1.5G.
On the bright side code is trivial and there is no need for some special tool to manage blobs.
Note: this is untested as I can't seem to run orbital on linux properly (it is stuck way before anything touching samu)