Fix override usage

AlexanderLanin · Aug 23, 2020 · 0999ab5 · 0999ab5
1 parent c2a6ea1
commit 0999ab5
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/src/ResultDumper.hpp b/src/ResultDumper.hpp
@@ -28,13 +28,13 @@ class ResultDumper : public Result::Reader::Consumer
 public:
   ResultDumper(FILE* stream);
 
-  virtual void on_header(CacheEntryReader& cache_entry_reader);
-  virtual void on_entry_start(uint32_t entry_number,
+  void on_header(CacheEntryReader& cache_entry_reader) final;
+  void on_entry_start(uint32_t entry_number,
                               Result::FileType file_type,
                               uint64_t file_len,
-                              nonstd::optional<std::string> raw_file);
-  virtual void on_entry_data(const uint8_t* data, size_t size);
-  virtual void on_entry_end();
+                              nonstd::optional<std::string> raw_file) final;
+  void on_entry_data(const uint8_t* data, size_t size) final;
+  void on_entry_end() final;
 
 private:
   FILE* m_stream;

diff --git a/src/ResultExtractor.hpp b/src/ResultExtractor.hpp
@@ -31,13 +31,13 @@ class ResultExtractor : public Result::Reader::Consumer
 public:
   ResultExtractor(const std::string& directory);
 
-  virtual void on_header(CacheEntryReader& cache_entry_reader);
-  virtual void on_entry_start(uint32_t entry_number,
+  void on_header(CacheEntryReader& cache_entry_reader) final;
+  void on_entry_start(uint32_t entry_number,
                               Result::FileType file_type,
                               uint64_t file_len,
-                              nonstd::optional<std::string> raw_file);
-  virtual void on_entry_data(const uint8_t* data, size_t size);
-  virtual void on_entry_end();
+                              nonstd::optional<std::string> raw_file) final;
+  void on_entry_data(const uint8_t* data, size_t size) final;
+  void on_entry_end() final;
 
 private:
   const std::string m_directory;

diff --git a/src/ResultRetriever.hpp b/src/ResultRetriever.hpp
@@ -31,13 +31,13 @@ class ResultRetriever : public Result::Reader::Consumer
 public:
   ResultRetriever(Context& ctx, bool rewrite_dependency_target);
 
-  virtual void on_header(CacheEntryReader& cache_entry_reader);
-  virtual void on_entry_start(uint32_t entry_number,
+  void on_header(CacheEntryReader& cache_entry_reader) final;
+  void on_entry_start(uint32_t entry_number,
                               Result::FileType file_type,
                               uint64_t file_len,
-                              nonstd::optional<std::string> raw_file);
-  virtual void on_entry_data(const uint8_t* data, size_t size);
-  virtual void on_entry_end();
+                              nonstd::optional<std::string> raw_file) final;
+  void on_entry_data(const uint8_t* data, size_t size) final;
+  void on_entry_end() final;
 
 private:
   Context& m_ctx;

diff --git a/src/third_party/fmt/core.h b/src/third_party/fmt/core.h
@@ -99,7 +99,7 @@
 #endif
 
 #ifndef FMT_OVERRIDE
-#  if FMT_HAS_FEATURE(cxx_override) || \
+#  if FMT_HAS_FEATURE(cxx_override_control) || \
       (FMT_GCC_VERSION >= 408 && FMT_HAS_GXX_CXX11) || FMT_MSC_VER >= 1900
 #    define FMT_OVERRIDE override
 #  else