Fix compatibility with HA 2024.4 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data This commit updates the `listener` function within the Yandex Station integration to support a change introduced in version 2024.4.0, where event data can be passed directly as a `Mapping[str, Any]` instead of an `Event` object. The update involves checking the type of the `event_data` parameter and extracting the data from it if it's an instance of `Event`. This change ensures compatibility with Home Assistant's evolving event model while maintaining performance by using a direct type check rather than `isinstance`, which is slower. The adjustment is critical for ensuring that the Yandex Station integration continues to function correctly without breaking due to the structural changes in how events are passed to listeners in Home Assistant versions 2024.4.0 and onwards.
AlexxIT
approved these changes
Apr 5, 2024
|
Thanks! |
AlexxIT
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
home-assistant/core#113798