Skip to content

Commit

Permalink
fixig e2es - task and version
Browse files Browse the repository at this point in the history
  • Loading branch information
VitoAlbano committed Dec 17, 2023
1 parent 3621d80 commit c615d4c
Show file tree
Hide file tree
Showing 12 changed files with 34 additions and 17 deletions.
2 changes: 1 addition & 1 deletion e2e/process-services/pages/task-filters-demo.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class TaskFiltersDemoPage {
return new TaskFiltersPage(this.involvedTask);
}

customTaskFilter(filterName: string): TaskFiltersPage {
customTaskFilter(filterName: string): TaskFiltersPage {
return new TaskFiltersPage($(`button[data-automation-id="${filterName}_filter"]`));
}

Expand Down
9 changes: 9 additions & 0 deletions e2e/process-services/pages/tasks-list.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import { browser, $, $$ } from 'protractor';
export class TasksListPage {

taskList = $('adf-tasklist');
selectedTab = $('[data-automation-id="navigation-bar"] .mdc-tab--active .mdc-tab__text-label');
taskTab = $$('[data-automation-id="navigation-bar"] .mdc-tab__text-label').first();
noTasksFound = $$('.adf-empty-content__title').first();
dataTable = new DataTableComponentPage(this.taskList);

Expand Down Expand Up @@ -61,4 +63,11 @@ export class TasksListPage {
return BrowserActions.getText(this.noTasksFound);
}

async selectTaskTab() {
const currentTab = await BrowserActions.getText(this.selectedTab);
if(currentTab && currentTab.toLowerCase().trim() !== 'tasks') {
await BrowserActions.click(this.taskTab);
}
}

}
1 change: 1 addition & 0 deletions e2e/process-services/tasks/task-filters-sorting.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ describe('Task Filters Sorting', () => {
await userFiltersUtil.createUserTaskFilter(newFilter);

await browser.refresh();
await tasksListPage.selectTaskTab();
await taskFiltersDemoPage.customTaskFilter(newFilter.name).clickTaskFilter();

await expect(await tasksListPage.getDataTable().contentInPosition(1)).toBe(tasks[2].name);
Expand Down
2 changes: 1 addition & 1 deletion lib/content-services/src/lib/social/rating.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ $adf-average-star-color: #808080;
width: 25px;

/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
.mat-list-item-content {
.mdc-list-item__content {
padding: 0 !important;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ adf-tags-creator {
}

/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
.mat-list-item-content-reverse {
.mdc-list-item__content-reverse {
padding: 0 6px;

.mat-pseudo-checkbox {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
.adf-version-list {
/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
.mat-list-item-content {
.mdc-list-item__content {
border-bottom: 1px solid #d8d8d8;

span {
display: flex;
align-items: center;
}

p.mat-line {
display: flex;
}
}

&-item-version {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
adf-version-manager {
.mat-mdc-list .mat-3-line {
.mat-mdc-list {
height: auto !important;
width: 100% !important;
}

/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
.mat-list-item-content {
.mdc-list-item__content {
padding: 16px 0 !important;
}
}

.adf-version-list-item-comment.mat-line {
.adf-version-list-item-comment .mat-line {
height: 100%;
word-break: break-all;
white-space: unset !important;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}

/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
.mat-nav-list .mat-mdc-list-item .mat-list-item-content {
.mat-nav-list .mat-mdc-list-item .mdc-list-item__content {
line-height: 48px;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@

&-attach-files-row {
/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
div.mat-list-item-content {
div.mdc-list-item__content {
cursor: pointer;
}

Expand All @@ -109,7 +109,7 @@

&-attach-selected-file-row {
/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
div.mat-list-item-content {
div.mdc-list-item__content {
.adf-datatable-selected {
color: var(--theme-primary-color);
padding-right: 6px;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</mat-error>
</mat-form-field>
</div>
<div class="input-row">
<div class="adf-input-row">
<mat-form-field>
<input
matInput
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
flex-direction: column;
display: flex;

.adf-task-name, .adf-task-description, .input-row {
.adf-task-name,
.adf-task-description {
display: flex;
margin-bottom: 10px;

Expand All @@ -29,7 +30,7 @@
}
}

.input-row {
.adf-input-row {
@include layout-bp(lt-md) {
flex-direction: column;
}
Expand Down Expand Up @@ -94,7 +95,6 @@ adf-start-task {
}

.adf {
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
&-start-task-input-container .mat-mdc-text-field-wrapper {
padding-top: 8px;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class TogglePage {

async enableToggle(toggle: ElementFinder): Promise<void> {
const check = await BrowserActions.getAttribute(toggle, 'class');
if (check.indexOf('mdc-switch--unselected') < 0) {
if (check.indexOf('mat-mdc-slide-toggle-checked') < 0) {
await BrowserActions.click(toggle);
}
}
Expand Down

0 comments on commit c615d4c

Please sign in to comment.