[AAE-19343] Fix attach file widget advanced properties are not properly displayed #9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alep85
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
alep85
requested review from
swapnil-verma-gl
and removed request for
DenysVuika,
eromano and
popovicsandras
alep85
changed the title
|
The changes proposed here are impacting the UI for the properties panel as well as the create rules popup window in ACA/ADW. See screenshots - |
eromano
approved these changes
Jan 12, 2024
|
@swapnil-verma-gl if this style is needed in the meta data card view component that use the card view please move this @alep85 and @swapnil-verma-gl move this needed style in there instead of the core component |
alep85
force-pushed
the
dev-alepore-AAE-19343
branch
from
2e622ff to
1670ede
Compare
eromano
approved these changes
Jan 12, 2024
…label overlaps the selected variable, fix remove empty space between static path label and the value
alep85
force-pushed
the
dev-alepore-AAE-19343
branch
from
1670ede to
6858e06
Compare
|
DenysVuika
reviewed
Jan 15, 2024
| @@ -66,7 +65,10 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| height: 20px; | |||
| transform: translateY(-1.3437em) scale(1); | |||
|
|
|||
| &.mat-form-field-empty { | |||
There was a problem hiding this comment.
you are using .mat- styles that should not be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-19343
What is the new behaviour?
The selected variable is not overlapped and there's no extra space between
Static Pathlabel and the valueDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: