-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 3 API changes #19
Conversation
👍 yes a dedicated |
Pulled in https://github.com/AliSoftware/Reusable/tree/swift3 👍 Thx a lot. I've added you as collaborator for the occasion (so you can create branch directly on Reusable in the future instead of needing your own fork) |
💃 Sweet! |
Please don't forget to add an additional commit on this new branch to:
Once you've done that, with your new collaborator rights you'll be able to check those checkboxes above (I think) and close the PR at last. [EDIT] oh wait can't reopen the PR now that the branch is deleted on your fork, of course. Never mind. Just don't forget to update the README & CHANGELOG then 😉 |
Just realized |
I'll open a new PR for those metadata changes. Taking a step back, should this change be using conditional compilation markers like |
Ohh right it's definitely worth adding If you do that then not sure about the README then as the PR will indeed be merged into master and code will be valid for both Swift 2+3 so probably not worth updating the references to Swift 2 APIs in the README? |
Targeting
master
as it's the only branch. Do you want this in a separateswift3
branch?