fix(log): ETH-1685 instantiate logrus with non-nil io.Writer #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications built with
github.com/AlluvialFinance/go-utils/app.App
appear to be panicking at runtime when built with go 1.22Upon closer inspection of the
github.com/AlluvialFinance/go-utils/log
package, it appears that the logger called inNew(cfg *config.Config)
is being instantiated without a specifyingLogger.Out
.This PR
log
package so thatNew()
returns an interface. We can consider alternative implementations in future but this will also help with unit testing.Logger
with the default values, including a writer to StdErr.1.20
-->1.22