Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: angular 19 #2612

Merged
merged 1 commit into from
Jan 15, 2025
Merged

chore: angular 19 #2612

merged 1 commit into from
Jan 15, 2025

Conversation

vscaiceanu-1a
Copy link
Member

@vscaiceanu-1a vscaiceanu-1a commented Dec 18, 2024 •
edited
Loading

Proposed change

Migrate to Angular 19

TODO

Related issues

- No issue associated -

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 18, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 55bd61f.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 59m 47s View ↗
nx run-many --target=test-e2e ✅ Succeeded 2m 52s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 32s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 7s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded 33s View ↗
nx affected --target=test --cacheDirectory=/hom... ✅ Succeeded 17s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 11:35:43 UTC

@vscaiceanu-1a vscaiceanu-1a force-pushed the chore/angular-19 branch 3 times, most recently from 44eac4e to 1056208 Compare January 14, 2025 10:09
sdo-1A
sdo-1A previously approved these changes Jan 14, 2025
View reviewed changes
@vscaiceanu-1a vscaiceanu-1a force-pushed the chore/angular-19 branch 13 times, most recently from f03e237 to 7bcf11a Compare January 15, 2025 09:00
sdo-1A
sdo-1A previously approved these changes Jan 15, 2025
View reviewed changes
fpaul-1A
fpaul-1A reviewed Jan 15, 2025
View reviewed changes
tools/github-actions/new-version/packaged-action/LICENSE.txt Outdated
@@ -94,33 +94,6 @@ FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
IN THE SOFTWARE.

@o3r/new-version
Copyright Amadeus SAS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted

@vscaiceanu-1a vscaiceanu-1a merged commit 03a15a6 into release/12.0.0-next Jan 15, 2025
34 of 36 checks passed
@vscaiceanu-1a vscaiceanu-1a deleted the chore/angular-19 branch January 15, 2025 13:09
@vscaiceanu-1a vscaiceanu-1a mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulve-1A cpaulve-1A cpaulve-1A left review comments

@sdo-1A sdo-1A sdo-1A approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

Assignees
No one assigned
Labels
project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/swagger-builder project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:audit-gh-action project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/build-helpers project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dev-tools project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-config-otter project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/logger project:@o3r/mobile project:@o3r/new-version project:@o3r/pipeline project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/storybook project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:@o3r/workspace-helpers project:@o3r-training/showcase-sdk project:@o3r-training/training-tools project:otter-devtools project:release-gh-action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vscaiceanu-1a @kpanot @fpaul-1A @cpaulve-1A @sdo-1A