Check for camera availability before switching #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AmolGangadhare any feedback? |
piotrsed
approved these changes
Feb 21, 2022
ihsansariyerlioglu
approved these changes
Apr 14, 2022
|
@AmolGangadhare Can you give feedback about this merge? I think this should already be in the codebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With devices having only 1 camera, pressing "Switch camera" icon will crash the app with the following exception:
This make sure the desired camera is available before the switch.
I didn't make the changes for iOS, because all devices running iOS have both front & back camera.