Cleanup filter tests, move to single file #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reorganizing the view tests, it was apparent there were 2 places testing for the view logic. This is a artifact from the time before QueryFilterEngine was written (and DynamicFilterSet was a thing). These tests all happen on the view level, and are grouped in a consistent readible whole.
This makes it easier to expand test conditions, and uncovered some missing bits (resolved in earlier commits).
vdboor
force-pushed
the
diederik/cleanup-filter-tests
branch
from
3396bb6 to
05a9813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out there were multiple places were filtering tests happened.
The mandatory filter tests I wrote back then had a lot of code in a single test. This is now split into separate tests, and parametrized tests to make this easier to read and extend.