Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port gebieden.map to refdb #479

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Port gebieden.map to refdb #479

wants to merge 1 commit into from

Conversation

lbam
Copy link
Contributor

@lbam lbam commented Feb 16, 2024

Not everything is ported over, because not everything is in the refdb yet. Relevant parts of the mapfile generator have been marked.

@lbam lbam force-pushed the lb/gebieden branch 2 times, most recently from f1e919d to 730456c Compare February 19, 2024 08:54
UNESCO zones still read from legacy database because the data hasn't
landed in the refdb yet. See gen_gebieden.py for more loose ends.
Copy link
Contributor

@jjmurre jjmurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, question about naming.
Nice approach with the blocks!

gen_gebieden.py Show resolved Hide resolved
gen_gebieden.py Show resolved Hide resolved
@lbam lbam marked this pull request as draft February 19, 2024 09:19
@lbam
Copy link
Contributor Author

lbam commented Feb 19, 2024

Converted back to draft as the structure of this mapfile needs further reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants