Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current location button to map #650

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Conversation

alimpens
Copy link
Collaborator

@alimpens alimpens commented Jan 7, 2025

Meldingen

Ticket: SIG-6185

Before opening a pull request, please ensure:

  • Double-check your branch is based on main and targets main
  • Code is well-commented, linted and follows project conventions

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

@alimpens alimpens requested a review from vdegraaf January 7, 2025 13:14
Copy link
Collaborator

@vdegraaf vdegraaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I cannot test properly since I'm not im Amsterdam. Brings me to the point: it doenst give a warning when you're outside the municipalities' borders when clicking on the location button. Should that be added?

@alimpens
Copy link
Collaborator Author

alimpens commented Jan 7, 2025

Looks good, although I cannot test properly since I'm not im Amsterdam. Brings me to the point: it doenst give a warning when you're outside the municipalities' borders when clicking on the location button. Should that be added?

Definitely, but I think that's a new feature / ticket?

@vdegraaf vdegraaf self-requested a review January 13, 2025 13:50
@alimpens alimpens merged commit 6be8c0e into main Jan 13, 2025
3 checks passed
@alimpens alimpens deleted the 6185-add-current-location-button branch January 13, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants