-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current location button to map #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I cannot test properly since I'm not im Amsterdam. Brings me to the point: it doenst give a warning when you're outside the municipalities' borders when clicking on the location button. Should that be added?
apps/public/src/app/(map)/locatie/kies/_components/BaseLayer.test.tsx
Outdated
Show resolved
Hide resolved
Definitely, but I think that's a new feature / ticket? |
…into 6185-add-current-location-button
Meldingen
Ticket: SIG-6185
Before opening a pull request, please ensure:
main
and targetsmain
Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)