MIJN-9682-Feature/blokkeren-stadspas #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoanPaulus
force-pushed
the
MIJN-9682-Feature/blokkeren-stadspas
branch
from
098fdad to
0cf3c41
Compare
RoanPaulus
force-pushed
the
MIJN-9682-Feature/blokkeren-stadspas
branch
from
0cf3c41 to
7b3c9a4
Compare
…t to see which routers are in use
* Fix types * Fix implementation * Refine types * Refine type * Juggle around references, change name * Change mock server responses (add dynamic props) * Change name * Change http verb * Rename hook * Enable delay * Change markup * FIx type * Add deprecation (boyscout) * Rename * Styling
…to MIJN-9682-Feature/blokkeren-stadspas
|
Ik had nog even code aangepast om En nog een paar tests erbij gemaakt voor de frontend. Ik vind data-testid attribuut wel heel fijn en clean om mee te testen. Voeg het toe en boem het vind het wel of niet zonder enige vraag of m'n selector wel goed is of analyse van een snapshot. Weet alleen niet of ik dat helemaal goed doe (Misschien is de bedoeling ook dat het niet gerendered word in de frontend? en dat gebeurd nu wel) maar vitest pikt dat attribuut in iedergeval automatisch op met |
timvanoostrom
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.