Fix Mode switch for AP #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Rename HACS release and disable zipped source" This reverts commit 532babc. Delete custom_components/.DS_Store Delete .DS_Store Revert Changes Added power and light level Update const.py Revert machMode back to original settings value Rename HACS release and disable zipped source
Disable ZIP Release and rename in HACS
Andre0512
requested changes
Aug 14, 2024
This reverts commit dec964b.
|
Apologies, I hadn't realised those commits had made it into my PR. Those should be reverted now! |
|
Hi, this PR should be good to go now, is it ok to merge it? |
Bring in updates from main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've identified an issue which I believe may be related to this bug: #167
What I've found is with the H-PURIFIER 700 Air Purifier, changing the mode actually switches off the AP. It behaves like it doesn't like the mode switch and almost crashes.
I've found that by making this change, this makes the mode switch reliable again. It's still not possible to turn the AP on/off however, I did attempt to expose this but concluded the only way to do this reliably would be to use the programs, which by default pass parameters such as turning the light off.
This PR removes the 0: "standby" mode which appears to be invalid, as the valid options listed from the output of the AP are only 1-4. It's worth noting option 3 doesn't seem to do anything, but removing it just meant it was replaced with a 3 so I left it in.