Skip to content

Commit

Permalink
fix: feedback from peer review
Browse files Browse the repository at this point in the history
  • Loading branch information
fubuloubu committed May 2, 2024
1 parent 152876d commit f5e5d2f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions silverback/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ def add_taskiq_task(handler: Callable) -> AsyncTaskiqDecoratedTask:
# Address is almost a certainty if the container is being used as a filter here.
if contract_address := getattr(container.contract, "address", None):
labels["contract_address"] = contract_address
# NOTE: event signature is a string with spaces/commas, so encapsulate it in quotes
labels["event_signature"] = f'"{container.abi.signature}"'

broker_task = self.broker.register_task(
Expand Down
1 change: 0 additions & 1 deletion silverback/recorder.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def _extract_custom_metrics(cls, result: Any, task_name: str) -> dict[str, Datap
logger.warning(f"Cannot handle return type of '{task_name}': '{type(result)}'.")
return {}

# else:
converted_result = {}

for metric_name, metric_value in result.items():
Expand Down

0 comments on commit f5e5d2f

Please sign in to comment.