Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): dump default profile.toml by alias (so it works) #134

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(client): dump default profile.toml by alias (so it works) #134

merged 2 commits into from
Oct 10, 2024

Conversation

fubuloubu
Copy link
Member

What I did

If you copy/paste some of the defaults into a custom profile, it won't work because it wasn't dumped by alias

You can fix an existing file by just replacing client_id with client-id

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu enabled auto-merge (squash) October 10, 2024 16:35
@fubuloubu fubuloubu merged commit 4756575 into main Oct 10, 2024
21 checks passed
@fubuloubu fubuloubu deleted the fix/profile-by-alias branch October 10, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnson2427 johnson2427 johnson2427 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fubuloubu @johnson2427