Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ModuleNotFound on run cmd #169

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 4, 2024

What I did

Tried running silverback run in a random directory to see what happens. Got ModuleNotFounder error which I thought was kind of strange. I attempted to improve the experience there.

How I did it

Another try and except and this time raise click.BadParameter

How to verify it

Go to a random directory with no bots.
Run silverback run

Should see:

Usage: silverback run [OPTIONS] [BOT]
Try 'silverback run --help' for help.

Error: Invalid value for '[BOT]': Nothing ro run: No bot argument(s) given and no bots module found.

Is much better than it was.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey force-pushed the fix/no-module-named-bots branch from bc72d9d to b055f94 Compare November 4, 2024 16:52
@fubuloubu fubuloubu merged commit 6a2df5b into ApeWorX:main Nov 4, 2024
13 checks passed
@antazoey antazoey deleted the fix/no-module-named-bots branch November 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants