Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster credentials to fit new schema #181

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Jan 6, 2025

What I did

Fixing the cluster registry credentials to connect with the cluster.

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@Ninjagod1251
Copy link
Contributor

currently working on this issue:

sbc registry auth new test-name test-registry
Username: chris
Password: 
Email: [email protected]

Error message

Field required [type=missing, input_value={'name': 'test-name', 'do...ocker_email': '[email protected]'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.7/v/missing
hostname
  Field required [type=missing, input_value={'name': 'test-name', 'do...ocker_email': '[email protected]'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.7/v/missing
created
  Field required [type=missing, input_value={'name': 'test-name', 'do...ocker_email': '[email protected]'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.7/v/missing
updated
  Field required [type=missing, input_value={'name': 'test-name', 'do...ocker_email': '[email protected]'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.7/v/missing

@@ -268,9 +268,8 @@ def health(self) -> ClusterHealth:
def registry_credentials(self) -> dict[str, RegistryCredentials]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to change this interface because it doesn't match this anymore

@Ninjagod1251 Ninjagod1251 self-assigned this Jan 7, 2025
@@ -788,8 +788,8 @@ def registry():
@cluster_client
def credentials_list(cluster: "ClusterClient"):
"""List container registry credentials"""

if creds := list(cluster.registry_credentials):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tab may cause issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants