-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shutdown issues [SBK-358] #43
Conversation
SBK-358 "fix: shutdown issues" (ApeWorX/silverback #43)
What I didThere was a bunch of non-critical issues when a Silverback app is shutdown via external means How I did it
How to verify itplay with it Checklist
ApeWorX/silverback #43 by fubuloubu on GitHub via LinearSync |
93b39e7
to
9fd0b6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeshultz approve this and we can merge/release
I'm not entirely sure if this is good to go or not. Can't run the example app. The tokenlists package requires pydantic 1. So either I'm missing something with the compat, or we need that to update for the example app to run. @fubuloubu if you're okay with this being untested, lmk and I'll ✔️ this. |
This seems to have some issues with pydantic v2 compatibility. TaskIQ has some internals that allow it to handle pydantic model serialization. And the way it detects which way to go is via the installed package version: When it tries to call
I think this might be an issue with the |
Reported in ApeWorX/ape#1736 |
Unless we do something like implement |
The only solution I can see it is wait for Ape 0.7 which will have proper v2 support. Sorry - I didn't realize where you were seeing this issue before but now I understand! |
closed in favor of #65 |
What I did
There was a bunch of non-critical issues when a Silverback app is shutdown via external means
How I did it
How to verify it
play with it
Checklist
- [ ] New test cases have been added and are passing- [ ] Documentation has been updated