feat!: Handle 0.7 breaking changes and updates [SBK-369] #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Nov 22, 2023
NotPeopling2day
force-pushed
the
feature/ape-1543
branch
from
faa28ba to
40d54a0
Compare
NotPeopling2day
force-pushed
the
feature/ape-1543
branch
from
8a12b07 to
1c944ed
Compare
NotPeopling2day
changed the title
fubuloubu
force-pushed
the
feature/ape-1543
branch
from
1c944ed to
c2f8cd9
Compare
fubuloubu
force-pushed
the
feature/ape-1543
branch
from
b69d08e to
bc5b6e1
Compare
fubuloubu
previously approved these changes
Dec 20, 2023
fubuloubu
requested review from
mikeshultz and
antazoey
and removed request for
antazoey
|
@antazoey if you can check the updates I made to CLI |
mikeshultz
reviewed
Dec 20, 2023
I ran the in-memory broker example from the README Would need more testing with some other usecases, specifically with the worker and with persistence |
antazoey
reviewed
Dec 20, 2023
NOTE: raises if mismatch
fubuloubu
approved these changes
Jan 2, 2024
fubuloubu
reviewed
Jan 2, 2024
| os.environ["SILVERBACK_NETWORK_CHOICE"] = val | ||
| # NOTE: Make sure both of these have the same setting | ||
| if env_network_choice := os.environ.get("SILVERBACK_NETWORK_CHOICE"): | ||
| if val.network_choice != env_network_choice: |
There was a problem hiding this comment.
Note: @mikeshultz noticed if you use the shortened form in the environment variable, that the selection would be fully resolved and thus be mismatching
easy fix is to just update the environment variable to the fully resolved form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #
How I did it
How to verify it
Checklist