Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include args for __exit__ func sig [SBK-371] #47

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

mikeshultz
Copy link
Contributor

What I did

The func sig changed in ProviderContextManager.__exit__() requiring the expected arguments. This fixes the atexit.register() call to include the required args expected by object.__exit__().

Change introduced in Ape framework in PR ApeWorX/ape#1733

How I did it

None

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@mikeshultz mikeshultz self-assigned this Nov 24, 2023
@vany365 vany365 changed the title fix: include args for __exit__ func sig fix: include args for __exit__ func sig [SBK-371] Nov 24, 2023
Copy link

linear bot commented Nov 24, 2023

SBK-371 "fix: include args for __exit__ func sig" (ApeWorX/silverback #47)

What I did

The func sig changed in ProviderContextManager.__exit__() requiring the expected arguments. This fixes the atexit.register() call to include the required args expected by object.__exit__().

Change introduced in Ape framework in PR ApeWorX/ape#1733

How I did it

None

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ApeWorX/silverback #47 by mikeshultz on GitHub

via LinearSync

@mikeshultz
Copy link
Contributor Author

Should probably cut a release immediately since this causes an issue with the latest version of Ape.

@fubuloubu fubuloubu merged commit 2e00106 into main Nov 24, 2023
26 checks passed
@fubuloubu fubuloubu deleted the fix/exit branch November 24, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants