Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: task ID and persistence discrepancy #48

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix: task ID and persistence discrepancy #48

merged 4 commits into from
Dec 5, 2023

Conversation

mikeshultz
Copy link
Contributor

What I did

Fixes a minor discrepancy between handler_id and task_id. This caused log_index and block number to not be set.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@mikeshultz mikeshultz added the bug Something isn't working label Dec 5, 2023
@mikeshultz mikeshultz requested a review from fubuloubu December 5, 2023 22:30
@mikeshultz mikeshultz self-assigned this Dec 5, 2023
@mikeshultz mikeshultz merged commit 96453b6 into main Dec 5, 2023
25 checks passed
@mikeshultz mikeshultz deleted the fix/taskname branch December 5, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees

@mikeshultz mikeshultz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeshultz @fubuloubu