Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if BROKER_URI is not defined, give the constructor None #60

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: if BROKER_URI is not defined, give the constructor None #60

merged 1 commit into from
Mar 27, 2024

Conversation

mikeshultz
Copy link
Contributor

What I did

Prevents an empty string from being given to a broker class if SILVERBACK_BROKER_URI is not defined.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@mikeshultz mikeshultz added the bug Something isn't working label Mar 26, 2024
@mikeshultz mikeshultz self-assigned this Mar 26, 2024
@mikeshultz mikeshultz requested a review from fubuloubu March 26, 2024 08:47
@mikeshultz mikeshultz merged commit d5c33a9 into main Mar 27, 2024
26 checks passed
@mikeshultz mikeshultz deleted the fix/broker-uri branch March 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees

@mikeshultz mikeshultz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeshultz @fubuloubu