refactor: allow multiple handlers #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fubuloubu
requested review from
mikeshultz,
antazoey,
NotPeopling2day and
johnson2427
and removed request for
antazoey
mikeshultz
reviewed
Apr 9, 2024
fubuloubu
commented
Apr 9, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
antazoey
reviewed
Apr 9, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
antazoey
reviewed
Apr 10, 2024
antazoey
previously approved these changes
Apr 10, 2024
mikeshultz
reviewed
Apr 10, 2024
antazoey
reviewed
Apr 11, 2024
mikeshultz
approved these changes
Apr 11, 2024
antazoey
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Refactor to dynamic registration of tasks, saving tasks (and their handlers) in a separate collection that can be accessed via an enum type to specify their class
Relates to #57, as it migrates to a dynamic registration method via TaskIQ
Also should allow #55 (comment) to use dynamic registration to resolve the bug with multiple handlers with different filters not fully registering
How I did it
New TaskIQ dynamic broker registration API
How to verify it
Everything should work as it did before, don't think this is breaking but wanted to call attention to commits to make sure they were reviewed fully for breaking behaviors
Checklist
- [ ] New test cases have been added and are passing- [ ] Documentation has been updated