Fix popout StartupLocation bug #3481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This did not play nice if the window was maximized or minimized when it was saved.
A user can full-screen these by double-clicking the title bar, or using a Windows keyboard shortcut, but we don't want to default to that state even if the user did that before closing the window last time.
|
It's great to see this! A company here in Japan hit this issue and I had to get them to delete their config to restore their MP to working order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where a user can be persistently stuck with a full-screen sized, or a zero sized, EKF status window (or Vibe or PreArm messages windows). We don't allow the user to resize these windows, so the only way to fix it is with config.xml hacking (or deleting).
We hide the minimize/maximize buttons on these windows, but they can still be minimized or maximized in multiple ways: keyboard shortcut, double-clicking the titlebar, or from the context menu on the title bar. If the user does this, and then closes the window before restoring it, the size gets saved and it cannot be fixed through the UI.
This PR fixes this by saving the location and size of the
RestoreBoundsof the form, instead of the literal size.Additionally I made the EKF/Vibe/PreArm windows always open in normal state, regardless of the state they were in when they closed.